Skip to content

fix(epoxy): fix Any quorum type not reaching any node #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 16, 2025
Merged

fix(epoxy): fix Any quorum type not reaching any node #2910

merged 6 commits into from
Sep 16, 2025

Conversation

NathanFlurry
Copy link
Member

No description provided.

@NathanFlurry NathanFlurry mentioned this pull request Sep 12, 2025
Merged
@vercel Vercel
Copy link

vercel bot commented Sep 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Error Error Sep 15, 2025 6:16pm
rivet-site Ready Ready Preview Comment Sep 15, 2025 6:16pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rivet-studio Ignored Ignored Preview Sep 15, 2025 6:16pm

This was referenced Sep 12, 2025
Closed
Closed
Closed
Closed
Merged
Closed
Closed
This was referenced Sep 12, 2025
Closed
Closed
Merged
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Sep 12, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude Claude
Copy link

claude bot commented Sep 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 12, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2910

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2910

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2910

commit: c70a667

graphite-app[bot]
graphite-app bot reviewed Sep 12, 2025
View reviewed changes
packages/services/epoxy/src/http_client.rs
// Only require 1 response
utils::QuorumType::Any => 1,
// Include all responses
utils::QuorumType::All => responses.len(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: QuorumType::All sets target_responses to responses.len() (total responses), but the loop only counts successful_responses. If any responses fail, the code will wait indefinitely trying to collect more successful responses than possible. Should either: 1) Set target_responses to the number of nodes that haven't failed yet, or 2) Change the loop condition to account for failed responses when using QuorumType::All.

Spotted by Diamond

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

@NathanFlurry NathanFlurry mentioned this pull request Sep 12, 2025
Merged
This was referenced Sep 12, 2025
Closed
Open
Open
Draft
Draft
Draft
Merged
This was referenced Sep 13, 2025
Merged
Merged
@MasterPtato MasterPtato mentioned this pull request Sep 13, 2025
Merged
@NathanFlurry NathanFlurry force-pushed the 09-09-chore_runner_handle_async_actor_stop branch from 48dbdc9 to 0752ad1 Compare September 14, 2025 20:00
@NathanFlurry NathanFlurry force-pushed the 09-12-fix_epoxy_fix_any_quorum_type_not_reaching_any_node branch from edd939f to 0208166 Compare September 14, 2025 20:00
@claude Claude
Copy link

claude bot commented Sep 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Sep 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Sep 14, 2025
Merged
@jog1t jog1t force-pushed the 09-12-fix_epoxy_fix_any_quorum_type_not_reaching_any_node branch from 0208166 to edd939f Compare September 15, 2025 16:47
@claude Claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t mentioned this pull request Sep 15, 2025
Closed
@MasterPtato MasterPtato force-pushed the 09-12-fix_epoxy_fix_any_quorum_type_not_reaching_any_node branch from edd939f to c70a667 Compare September 15, 2025 18:04
@MasterPtato MasterPtato force-pushed the 09-09-chore_runner_handle_async_actor_stop branch from 48dbdc9 to e0afd30 Compare September 15, 2025 18:04
@claude Claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Sep 15, 2025
Merged
Merged
Base automatically changed from 09-09-chore_runner_handle_async_actor_stop to main September 16, 2025 08:06
@NathanFlurry NathanFlurry merged commit 2e35736 into main Sep 16, 2025
8 of 19 checks passed
@NathanFlurry NathanFlurry deleted the 09-12-fix_epoxy_fix_any_quorum_type_not_reaching_any_node branch September 16, 2025 08:06
@github-actions github-actions bot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFlurry @MasterPtato